Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error-log noise and split-package conflict while server startup #121

Merged
merged 3 commits into from
Nov 21, 2016

Conversation

rdhabalia
Copy link
Contributor

Motivation

  • Split-package issue due to netty artifact conflict
com.yahoo.pulsar.PulsarBrokerStarter - Uncaught exception in thread main: io.netty.util.internal.MathUtil.safeFindNextPositivePowerOfTwo(I)I
java.lang.NoSuchMethodError: io.netty.util.internal.MathUtil.safeFindNextPositivePowerOfTwo(I)I
        at io.netty.buffer.PoolThreadCache$MemoryRegionCache.<init>(PoolThreadCache.java:372) ~[netty-buffer-4.0.42.Final.jar:4.0.42.Final]
  • Error-logging noise: while deriving NIC path : below exception occurs while try to read nonSymbolicLink file
INFO  c.y.p.zookeeper.ZooKeeperDataCache   - [State:CONNECTED Timeout:30000 sessionid:0x1565cebba204ff5 local:/10.210.13
...skipping...
java.nio.file.NotLinkException: /sys/class/net/bonding_masters
        at sun.nio.fs.UnixFileSystemProvider.readSymbolicLink(UnixFileSystemProvider.java:495) ~[na:1.8.0_102]
        at java.nio.file.Files.readSymbolicLink(Files.java:1432) ~[na:1.8.0_102]
        at com.yahoo.pulsar.broker.loadbalance.impl.LinuxBrokerHostUsageImpl.isPhysicalNic(LinuxBrokerHostUsageImpl.java:162)

Modifications

  • exclude conflicting netty-buffer artifact
  • Precondition check while deriving NIC path to avoid error-logging noise

Result

  • It will fix broker-deployment failure which may occur due to split-package conflict.

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Nov 19, 2016
@rdhabalia rdhabalia added this to the 1.16 milestone Nov 19, 2016
@rdhabalia rdhabalia self-assigned this Nov 19, 2016
@yahoocla
Copy link

CLA is valid!

2 similar comments
@yahoocla
Copy link

CLA is valid!

@yahoocla
Copy link

CLA is valid!

@rdhabalia rdhabalia changed the title Shade Fix: Error-log noise and split-package conflict while server startup Nov 19, 2016
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, though can you split it in 2 PRs?

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit 6089dcb into apache:master Nov 21, 2016
sijie added a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
sijie added a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
* Add `join` interface to container to wait for a container (apache#121)

* add producers

* Effective-Once support

* Fix conflict after rebase

* add tests

* fix tests

* address the test

* Add more tests

* remove lombok from api

* remove getType

* Fix concurrent modification issue in the tests

* Register send future before enqueuing message

* improve the test

* Use conditional remove

* remove the check
massakam pushed a commit to massakam/pulsar that referenced this pull request Feb 9, 2021
* Includes Support for ZSTD and SNAPPY Compression

A version bump to the latest version of the Pulsar C++ library (2.6.1) was required to make use of the compression types. As the latest version of the C++ library requires GLIBCXX_3.4.22, the testing suite code was altered to automatically update the Docker image with the latest version of libstdc++6 and gcc-4.9 before executing the library tests.

* Update pulsar-version.txt

Co-authored-by: savearray2 <savearray2>
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
The default value for `listeners` is currently `PLAINTEXT://127.0.0.1:9092`, in which, the ip is the advertise address of Pulsar.
In K8S env. user usually need set `listeners` as config map of yaml file, and passed into pods,  it is not easy to get pod's "advertise address" and put it into yaml file.
This change will config the `listeners` to value `PLAINTEXT://{advertise.address}:9092` if it is not set. So most of the case user not need to config this parameter. 
This change only change the code path of protocol handler. Not change the KafkaBroker and KafkaStandalone, since they will be removed.

* auto config default listener for protocolHandler

* add comments in .conf
cbornet pushed a commit to cbornet/pulsar that referenced this pull request Aug 31, 2022
* [enh][managed-ledger] Add histogram for time in entry cache
* [enh][managed-ledger] Add summary for size of range read by dispatcher
* [enh][broker] add metric to observer duration ServerCnx is unwritable
* [enh][broker] add metric for dispatcher reads reduced due to unwritable ServerCnx
cbornet pushed a commit to cbornet/pulsar that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants