-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Error-log noise and split-package conflict while server startup #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA is valid! |
2 similar comments
CLA is valid! |
CLA is valid! |
rdhabalia
changed the title
Shade
Fix: Error-log noise and split-package conflict while server startup
Nov 19, 2016
merlimat
reviewed
Nov 20, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, though can you split it in 2 PRs?
merlimat
approved these changes
Nov 21, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* Add `join` interface to container to wait for a container (apache#121) * add producers * Effective-Once support * Fix conflict after rebase * add tests * fix tests * address the test * Add more tests * remove lombok from api * remove getType * Fix concurrent modification issue in the tests * Register send future before enqueuing message * improve the test * Use conditional remove * remove the check
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Feb 9, 2021
* Includes Support for ZSTD and SNAPPY Compression A version bump to the latest version of the Pulsar C++ library (2.6.1) was required to make use of the compression types. As the latest version of the C++ library requires GLIBCXX_3.4.22, the testing suite code was altered to automatically update the Docker image with the latest version of libstdc++6 and gcc-4.9 before executing the library tests. * Update pulsar-version.txt Co-authored-by: savearray2 <savearray2>
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
The default value for `listeners` is currently `PLAINTEXT://127.0.0.1:9092`, in which, the ip is the advertise address of Pulsar. In K8S env. user usually need set `listeners` as config map of yaml file, and passed into pods, it is not easy to get pod's "advertise address" and put it into yaml file. This change will config the `listeners` to value `PLAINTEXT://{advertise.address}:9092` if it is not set. So most of the case user not need to config this parameter. This change only change the code path of protocol handler. Not change the KafkaBroker and KafkaStandalone, since they will be removed. * auto config default listener for protocolHandler * add comments in .conf
cbornet
pushed a commit
to cbornet/pulsar
that referenced
this pull request
Aug 31, 2022
* [enh][managed-ledger] Add histogram for time in entry cache * [enh][managed-ledger] Add summary for size of range read by dispatcher * [enh][broker] add metric to observer duration ServerCnx is unwritable * [enh][broker] add metric for dispatcher reads reduced due to unwritable ServerCnx
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
netty-buffer
artifactResult